feat: add /vm.m_run message handler
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r3v4s
reviewed
Oct 19, 2023
| @@ -80,3 +86,16 @@ export const encodeVmAddPackage = (writer: protobuf.Writer, messageInfo: VmAddPa | |||
| } | |||
| return writer; | |||
| }; | |||
|
|
|||
| export const encodeVmRun = (writer: protobuf.Writer, messageInfo: VmAddPackage) => { | |||
There was a problem hiding this comment.
shouldn't it be messageInfo: VmRun ??
|
I tried to broadcast a transaction, but I got this error, can you help to investigate? 
|
jinoosss
reviewed
Oct 20, 2023
| writer.uint32(18).string(messageInfo.send); | ||
| } | ||
| if (messageInfo.package !== undefined) { | ||
| encodePackage(writer.uint32(18).fork(), messageInfo.package).ldelim(); |
There was a problem hiding this comment.
This simply seems to be the problem.
Change the size of the buffer in the 3rd argument.
18 -> 26
There was a problem hiding this comment.
@luciorubeens seems like protobuf has certain buf size value for nth args.
https://www.tabnine.com/code/javascript/functions/protobufjs/Writer/string
There was a problem hiding this comment.
Perfect, thank you guys, now it works
jinoosss
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handlers for the new message type: gnolang/gno#1001