Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements and Bug Fixes #80

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Enhancements and Bug Fixes #80

merged 4 commits into from
Aug 23, 2024

Conversation

ndegwamartin
Copy link
Collaborator

@ndegwamartin ndegwamartin commented Aug 22, 2024

  • Implements pagination for sync by REL.
  • Fixes character encoding issue when parsing custom HTTP responses

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 43.69%. Comparing base (712d495) to head (76a9a44).
Report is 25 commits behind head on main.

Files Patch % Lines
...ister/fhir/gateway/plugins/SyncAccessDecision.java 0.00% 13 Missing ⚠️
...er/fhir/gateway/plugins/endpoint/BaseEndpoint.java 0.00% 9 Missing ⚠️
...ay/plugins/endpoint/LocationHierarchyEndpoint.java 0.00% 4 Missing ⚠️
...y/plugins/endpoint/PractitionerDetailEndpoint.java 0.00% 4 Missing ⚠️
...way/plugins/PractitionerDetailsEndpointHelper.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #80      +/-   ##
============================================
- Coverage     45.01%   43.69%   -1.32%     
- Complexity      130      135       +5     
============================================
  Files            16       16              
  Lines          1213     1332     +119     
  Branches        146      157      +11     
============================================
+ Hits            546      582      +36     
- Misses          600      684      +84     
+ Partials         67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndegwamartin ndegwamartin changed the title Implement pagination for Sync by REL strategy Enhancements and Bug Fixes Aug 22, 2024
Copy link

@Lentumunai-Mark Lentumunai-Mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Tested it and it works great!

@ndegwamartin ndegwamartin merged commit e77b133 into main Aug 23, 2024
3 checks passed
@ndegwamartin ndegwamartin deleted the gateway-enhancements branch August 23, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants