Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 5 digit parks #106

Merged
merged 3 commits into from
Nov 14, 2023
Merged

support 5 digit parks #106

merged 3 commits into from
Nov 14, 2023

Conversation

k0emt
Copy link
Contributor

@k0emt k0emt commented Oct 24, 2023

updated regex and tests to support new 5 digit parks
goreleaser changes made because of deprecations/changes in goreleaser

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f0664d) 81.84% compared to head (8f27894) 81.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files          17       17           
  Lines        1366     1366           
=======================================
  Hits         1118     1118           
  Misses        214      214           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasrussellmurphy
Copy link

This would close #105 if accepted. Can this move forward?

Copy link
Collaborator

@jmMeessen jmMeessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your pull request not only correcting the regexp to support 6 digit POTA ref but also cleaning some other stuff.

fleprocess/validate.go Show resolved Hide resolved
@jmMeessen jmMeessen merged commit 9cdef88 into on4kjm:master Nov 14, 2023
5 checks passed
@k0emt k0emt deleted the 5-digit-parks branch January 14, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants