Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify message re OC_CAUSE=1 env var #806

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

pixelb
Copy link
Collaborator

@pixelb pixelb commented Oct 18, 2021

  • omegaconf/_utils.py: Fix typo, and clarify
    that one needs to set the environment variable
    to get the full backtrace

@pixelb pixelb requested review from Jasha10 and jieru-hu October 18, 2021 17:29
@pixelb
Copy link
Collaborator Author

pixelb commented Oct 18, 2021

Even though this is a comment, it's shown in the truncated backtrace and so should give accurate info

raise ex.with_traceback(sys.exc_info()[2]) # set end OC_CAUSE=1 for full backtrace
raise ex.with_traceback(sys.exc_info()[2]) # set environment var OC_CAUSE=1 for full backtrace
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the black linter will trigger a CI failure here due to line length.

Copy link
Collaborator

@jieru-hu jieru-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can probably land after #800 is merged so we can run CI :)

@Jasha10
Copy link
Collaborator

Jasha10 commented Oct 19, 2021

#800 is merged now.

* omegaconf/_utils.py: Fix typo, and clarify
that one needs to set the environment variable
to get the full backtrace
@pixelb pixelb merged commit a6a6ba2 into omry:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants