Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PR template #1119

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Create PR template #1119

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bac19e2
Create PR template
Jasha10 Aug 26, 2023
ad2366a
add `## Fixes Issue` section to PR template
Jasha10 Aug 31, 2023
d3f8631
Update .github/PULL_REQUEST_TEMPLATE.md
omry Sep 2, 2023
acce4b6
Update .github/PULL_REQUEST_TEMPLATE.md
Jasha10 Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!-- Thank you for sending a PR and taking the time to improve OmegaConf -->

## Motivation

(Write your motivation for proposed changes here.)

### Have you read the [Contributing Guidelines on pull requests](https://github.com/omry/omegaconf/blob/master/CONTRIBUTING.md)?

Yes/No

## Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

## Fixes

What issue does this PR fix? Use https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue to link this PR to a corresponding issue.

omry marked this conversation as resolved.
Show resolved Hide resolved
## Related PRs

(Is this PR part of a group of changes? Link the other relevant PRs.)