Replace "pattern" export with "getPattern" method #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2024
omrilotan
force-pushed
the
pattern_export
branch
from
8d0a063
to
9836092
Compare
omrilotan
added a commit
that referenced
this pull request
Feb 16, 2024
omrilotan
added a commit
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In builds where the tree-shaking was not removing the raw RegExp, it was causing breakage.
Resolution:
We will not expose the raw Regular expression. Instead - it will be safely built once with a fallback to a more naive pattern (no lookbehind).
This should:
Resolve #242
Resolve #236