Start the session immediately in the read loop #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omrikiei
approved these changes
Feb 9, 2023
|
I'm a little concerned that this change might break the networking sequence, and I need to test it (overall, I need to add tests to the tool) |
|
If it helps, we've been using this (3 of us) for the last several months (since this PR) without issue, so for the use case of PyCharm, it's pretty solid so far. |
|
I'm sold.. YOLO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon starting the read loop, immediately send the current session to initiate the connection with the remote end, rather than waiting for the first data packet from the pod.
Fixes #60