-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OMN-SB]: Setup storybook #360
Conversation
This pull request is being automatically deployed with Vercel (learn more). omnivore-prod – ./🔍 Inspect: https://vercel.com/omnivore/omnivore-prod/2o3m4Rx6Sqtv9ibNfaedq5HzjxDX omnivore-demo – ./🔍 Inspect: https://vercel.com/omnivore/omnivore-demo/5Zc9FuCT49AmR12fNC9LDyX2M91T |
Can you add some instructions on how to run storybook locally? |
@jacksonh Instruction added to PR Description |
Looks like we need a linting fix here. |
Hmm, no linting errors seem to be popping up? Storybook seems to be building just fine locally, also runs fine. Any way we can see error logs on Vercel? |
Ah sorry i forgot the vercel errors aren't public. Here's the error:
|
@jacksonh Alright, this has been fixed. Thanks!. So this was due to some mix-up between Storybooks CSS prop and Stitches CSS prop. (source: stitchesjs/stitches#897) |
Working on getting styling to work with Storybook. I added this, but need to resolve some webpack issues with font loading:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@jacksonh Right, I've added the config for the fonts. I see the "Inter" font works now, for the Toasts. |
Description
This PR implements setting up Storybook.
To run storybook locally:
cd packages/web
yarn install
yarn storybook
to start storybook on port 6006House Keeping
Ticket link (if applicable)
Types of changes
Remarks