-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: render highlight color in article note #215
Conversation
6999971
to
807b4c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great to me. Really appreciate it as this is one of the biggest request from the users
@aaachen Sorry I think the |
4106943
to
542c24a
Compare
improvement: settings refactor
@sywhb Fixed the conflicts in respect to master, lmk if you see any problem p.s. also removed the "Settings for Omnivore Plugin" and "General" headers according to the guideline here |
Looks great to me! |
feat: render highlight color in article note (#215)
Issue
Issue: #166
feature: render highlight color in article note
improvement: refactor settings tab into its own file
Description
Two options here for highlight css
css-class
style option in Highlightr pluginCaveat
Testing
Screenshots