Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make siteName and other variables in the article template available in the folder/file name settings #190

Merged
merged 1 commit into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 44 additions & 40 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ import {
import { FolderSuggest } from "./settings/file-suggest"
import {
preParseTemplate,
render,
renderArticleContnet,
renderFilename,
renderFolderName,
} from "./settings/template"
} from './settings/template'
import {
DATE_FORMAT,
findFrontMatterIndex,
Expand All @@ -35,7 +35,7 @@ import {
parseFrontMatterFromContent,
removeFrontMatterFromContent,
replaceIllegalChars,
} from "./util"
} from './util'

export default class OmnivorePlugin extends Plugin {
settings: OmnivoreSettings
Expand All @@ -59,33 +59,33 @@ export default class OmnivorePlugin extends Plugin {
}

this.addCommand({
id: "sync",
name: "Sync new changes",
id: 'sync',
name: 'Sync new changes',
callback: () => {
this.fetchOmnivore()
},
})

this.addCommand({
id: "deleteArticle",
name: "Delete Current Article from Omnivore",
callback: () => {
this.deleteCurrentArticle(this.app.workspace.getActiveFile())
}
id: 'deleteArticle',
name: 'Delete Current Article from Omnivore',
callback: () => {
this.deleteCurrentArticle(this.app.workspace.getActiveFile())
},
})

this.addCommand({
id: "resync",
name: "Resync all articles",
id: 'resync',
name: 'Resync all articles',
callback: () => {
this.settings.syncAt = ""
this.settings.syncAt = ''
this.saveSettings()
new Notice("Omnivore Last Sync reset")
new Notice('Omnivore Last Sync reset')
this.fetchOmnivore()
},
})

const iconId = "Omnivore"
const iconId = 'Omnivore'
// add icon
addIcon(
iconId,
Expand Down Expand Up @@ -143,10 +143,10 @@ export default class OmnivorePlugin extends Plugin {
const url = article.url
const response = await requestUrl({
url,
contentType: "application/pdf",
contentType: 'application/pdf',
})
const folderName = normalizePath(
renderFolderName(
render(
article,
this.settings.attachmentFolder,
this.settings.folderDateFormat
Expand Down Expand Up @@ -185,12 +185,12 @@ export default class OmnivorePlugin extends Plugin {
} = this.settings

if (syncing) {
new Notice("🐢 Already syncing ...")
new Notice('🐢 Already syncing ...')
return
}

if (!apiKey) {
new Notice("Missing Omnivore api key")
new Notice('Missing Omnivore api key')
return
}

Expand All @@ -200,17 +200,17 @@ export default class OmnivorePlugin extends Plugin {
try {
console.log(`obsidian-omnivore starting sync since: '${syncAt}'`)

manualSync && new Notice("🚀 Fetching articles ...")
manualSync && new Notice('🚀 Fetching articles ...')

// pre-parse template
frontMatterTemplate && preParseTemplate(frontMatterTemplate)
const templateSpans = preParseTemplate(template)
// check if we need to include content or file attachment
const includeContent = templateSpans.some(
(templateSpan) => templateSpan[1] === "content"
(templateSpan) => templateSpan[1] === 'content'
)
const includeFileAttachment = templateSpans.some(
(templateSpan) => templateSpan[1] === "fileAttachment"
(templateSpan) => templateSpan[1] === 'fileAttachment'
)

const size = 50
Expand All @@ -219,20 +219,20 @@ export default class OmnivorePlugin extends Plugin {
hasNextPage;
after += size
) {
[articles, hasNextPage] = await loadArticles(
;[articles, hasNextPage] = await loadArticles(
this.settings.endpoint,
apiKey,
after,
size,
parseDateTime(syncAt).toISO() || undefined,
getQueryFromFilter(filter, customQuery),
includeContent,
"highlightedMarkdown"
'highlightedMarkdown'
)

for (const article of articles) {
const folderName = normalizePath(
renderFolderName(article, folder, this.settings.folderDateFormat)
render(article, folder, this.settings.folderDateFormat)
)
const omnivoreFolder =
this.app.vault.getAbstractFileByPath(folderName)
Expand Down Expand Up @@ -285,7 +285,7 @@ export default class OmnivorePlugin extends Plugin {
!Array.isArray(newFrontMatter) ||
newFrontMatter.length === 0
) {
throw new Error("Front matter does not exist in the template")
throw new Error('Front matter does not exist in the template')
}
let newContentWithoutFrontMatter: string

Expand All @@ -302,7 +302,7 @@ export default class OmnivorePlugin extends Plugin {
const sectionEnd = `%%${article.id}_end%%`
const existingContentRegex = new RegExp(
`${sectionStart}.*?${sectionEnd}`,
"s"
's'
)
newContentWithoutFrontMatter =
existingContentWithoutFrontmatter.replace(
Expand Down Expand Up @@ -367,7 +367,7 @@ export default class OmnivorePlugin extends Plugin {
try {
await this.app.vault.create(normalizedPath, content)
} catch (error) {
if (error.toString().includes("File already exists")) {
if (error.toString().includes('File already exists')) {
new Notice(
`Skipping file creation: ${normalizedPath}. Please check if you have duplicated article titles and delete the file if needed.`
)
Expand All @@ -378,10 +378,10 @@ export default class OmnivorePlugin extends Plugin {
}
}

manualSync && new Notice("🔖 Articles fetched")
manualSync && new Notice('🔖 Articles fetched')
this.settings.syncAt = DateTime.local().toFormat(DATE_FORMAT)
} catch (e) {
new Notice("Failed to fetch articles")
new Notice('Failed to fetch articles')
console.error(e)
} finally {
this.settings.syncing = false
Expand All @@ -390,23 +390,27 @@ export default class OmnivorePlugin extends Plugin {
}

private async deleteCurrentArticle(file: TFile | null) {
if(!file) {
return
if (!file) {
return
}
//use frontmatter id to find the file
const articleId = this.app.metadataCache.getFileCache(file)?.frontmatter?.id
if (!articleId) {
new Notice("Failed to delete article: article id not found")
new Notice('Failed to delete article: article id not found')
}

try{
const isDeleted = deleteArticleById(this.settings.endpoint, this.settings.apiKey, articleId)
if(!isDeleted) {
new Notice("Failed to delete article in Omnivore")
}
try {
const isDeleted = deleteArticleById(
this.settings.endpoint,
this.settings.apiKey,
articleId
)
if (!isDeleted) {
new Notice('Failed to delete article in Omnivore')
}
} catch (e) {
new Notice("Failed to delete article in Omnivore")
console.error(e)
new Notice('Failed to delete article in Omnivore')
console.error(e)
}

await this.app.vault.delete(file)
Expand Down
Loading
Loading