fix: sort highlights by position percentage if available

omnivore-app · Apr 10, 2023 · 4a614c7 · 4a614c7
1 parent 0d63de8
commit 4a614c7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/main.ts b/src/main.ts
@@ -283,6 +283,15 @@ export default class OmnivorePlugin extends Plugin {
           if (highlightOrder === "LOCATION") {
             articleHighlights.sort((a, b) => {
               try {
+                // sort by highlight position percent if available
+                if (
+                  a.highlightPositionPercent !== undefined &&
+                  b.highlightPositionPercent !== undefined
+                ) {
+                  return (
+                    a.highlightPositionPercent - b.highlightPositionPercent
+                  );
+                }
                 if (article.pageType === PageType.File) {
                   // sort by location in file
                   return compareHighlightsInFile(a, b);

diff --git a/src/util.ts b/src/util.ts
@@ -88,6 +88,7 @@ export interface Highlight {
   updatedAt: string;
   labels?: Label[];
   type: HighlightType;
+  highlightPositionPercent?: number;
 }
 
 export interface HighlightPoint {
@@ -157,6 +158,7 @@ export const loadArticles = async (
                     patch
                     updatedAt
                     type
+                    highlightPositionPercent
                     labels {
                       name
                     }