Do not include query params in callback URLs #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be compatible with GitHub Integration's Oauth flow the callback URL must match the same one provided in the integration's settings page. The current `callback_url` method includes any query params received previously, which causes a mismatch, and GitHub returns "406 Not Accepted" with an error message: ``` (github) Callback phase initiated. (github) Authentication failure! invalid_credentials: OAuth2::Error, redirect_uri_mismatch: The redirect_uri MUST match the registered callback URL for this application. error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+ the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2 Fdeveloper.github.com%2Fv3%2Foauth%2F%23redirect-uri-mismatch2 ``` For more information: https://developer.github.com/early-access/integrations/user-identification-authorization
|
GitHub has confirmed that this is indeed the expected behaviour: https://platform.github.community/t/oauth-flow-with-integration-406-not-acceptable/1775/8 (last comment) |
|
@tmilewski any thoughts on this? |
|
@volmer I'll be able to look through this a little later today. Thanks! |
|
Woof, params like It is what it is. I'll pull it down, make sure everything is green and cut a build. Thanks for handling this! |
|
🎉 |
|
It's live as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be compatible with GitHub Integration's Oauth flow the callback URL must match the same one provided in the integration's settings page. The current
callback_urlmethod includes any query params received previously, which causes a mismatch, and GitHub returns "406 Not Accepted" with an error message:For more information:
https://developer.github.com/early-access/integrations/user-identification-authorization
Fixes #72