Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate methods to access the fee related Home and Foreign transfers #149

Closed
akolotov opened this issue Jan 31, 2019 · 1 comment
Closed

Separate methods to access the fee related Home and Foreign transfers #149

akolotov opened this issue Jan 31, 2019 · 1 comment
Assignees
@patitonar
Labels
in progress review

Comments

@akolotov
Copy link
Collaborator

Related to Issue 119 Rewards for bridge validators.

As it was identified in omni/bridge-ui#182, it is necessary to provide separate interfaces to access (setter and getter) the fee value related transfer from Home or from Foreign sides.

The current interface of the fee manager is:
https://github.com/poanetwork/poa-bridge-contracts/blob/b070322802880b53a2cc444cedb017d954088ad5/contracts/upgradeable_contracts/BaseFeeManager.sol#L26-L33

Consider to have the methods setHomeFee and setForeignFee. Therefore it will be getHomeFee and getForeignFee.
If the Fee Manager is in manages-one-direction mode (see #148) the method setFee will proxy one of the methods setHomeFee and setForeignFee depending on the side where the contract is deployed. Similar is for getFee.
@akolotov akolotov mentioned this issue Jan 31, 2019
Merged
@patitonar patitonar mentioned this issue Feb 1, 2019
Merged
@ghost ghost assigned patitonar Feb 1, 2019
@ghost ghost added the in progress label Feb 1, 2019
@patitonar patitonar mentioned this issue Feb 1, 2019
Merged
@ghost ghost added the in progress label Feb 1, 2019
akolotov added a commit that referenced this issue Feb 5, 2019
@akolotov
Merge pull request #151 from poanetwork/#149-separate-fee-home-foreig…
0f15d7f 
…n-transfers

Separate fee into home fee and foreign fee
@akolotov
Copy link
Collaborator Author

Available in the release 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patitonar patitonar

Labels
in progress review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patitonar @akolotov