Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contract submodule #220

Merged
merged 4 commits into from
May 24, 2019
Merged

Update contract submodule #220

merged 4 commits into from
May 24, 2019

Conversation

patitonar
Copy link

Updated contract submodule to version 2.3.1

@patitonar patitonar requested a review from akolotov May 23, 2019 21:03
@netlify
Copy link

netlify bot commented May 23, 2019

Deploy preview for kind-kilby-95344f processing.

Building with commit 0ca3248

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5ce7ff5909a2470008ae3f5a

@coveralls
Copy link

coveralls commented May 23, 2019

Pull Request Test Coverage Report for Build 498

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 9.244%

Totals Coverage Status
Change from base Build 488: 0.0%
Covered Lines: 122
Relevant Lines: 1436

💛 - Coveralls

Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need update the env files to deploy contracts since 2.1.0 and 2.3.1 have different set of fields?

@akolotov
Copy link
Collaborator

@patitonar e2e testing fails in the TravisCI:

npm ERR! code ENOLOCAL
npm ERR! Could not install from "node_modules/web3-providers-ws/websocket@git:/github.com/frozeman/WebSocket-Node.git#6c72925e3f8aaaea8dc8450f97627e85263999f2" as it does not contain a package.json file.

@patitonar
Copy link
Author

Thanks @akolotov I'm reviewing the issue, it seems that a dependency is having some issues to be fetched. It also affects the PR on the oracle

@akolotov
Copy link
Collaborator

akolotov commented May 24, 2019

Thanks @akolotov I'm reviewing the issue, it seems that a dependency is having some issues to be fetched. It also affects the PR on the oracle

Arsenii Petrovich reported yesterday about the same issue in his experiments. He solved it by removing package.json in the contracts repository.

@akolotov akolotov merged commit 0342e0a into master May 24, 2019
@akolotov akolotov deleted the update-contract-submodule branch May 24, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants