Update e2e tests urls #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Deploy preview for kind-kilby-95344f processing. Building with commit d8dc2fd https://app.netlify.com/sites/kind-kilby-95344f/deploys/5cdc1c6f0283370008a3facc |
akolotov
reviewed
May 16, 2019
There was a problem hiding this comment.
I think it makes sense to move implement these changes directly in the monorepo https://github.com/poanetwork/tokenbridge. What do you think?
rzadp
approved these changes
May 16, 2019
rzadp
added a commit
to omni/tokenbridge
that referenced
this pull request
May 16, 2019
akolotov
approved these changes
May 16, 2019
akolotov
approved these changes
May 16, 2019
rzadp
added a commit
to omni/tokenbridge
that referenced
this pull request
May 21, 2019
* Commented out package-lock.json * Moved over changes from omni/bridge-ui#217 * Brought back package-lock.json used in e2e. * Edited postinstall to work for sub-repo npm install * Using local oracle * Moved ui/e2e-script to ui-e2e * Introduced ui-e2e workspace. * Updated paths,. removed bridge dockerfile. * Updated e2e script after extracting. * Introduced ui-e2e into CI * Disabled ui-e2e * Updated readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216
@rzadp Please check if e2e tests are working now for you