Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add own web3-eth version #205

Merged
merged 7 commits into from
Mar 28, 2019
Merged

Add own web3-eth version #205

merged 7 commits into from
Mar 28, 2019

Conversation

patitonar
Copy link

This PR add web3 library inside the repo on lib directory. This web3 version is based on 1.0.0-beta.37 and includes getChainId method on web3-eth module.

preinstall script was added to correctly build and include the web3 library as dependency for the app.

Closes #204, using this version, we avoid the issues introduced before. While testing, only when I sent from ETC to ETH the false error of tx revert even if it was successful was present. So now we log the error but avoid stopping the UI flow

@ghost ghost assigned patitonar Mar 28, 2019
@netlify
Copy link

netlify bot commented Mar 28, 2019

Deploy preview for kind-kilby-95344f processing.

Building with commit fe27eba

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c9d2c416f5bc400088a6713

@ghost ghost added the in progress label Mar 28, 2019
@patitonar patitonar changed the title Add own web3 version Add own web3-eth version Mar 28, 2019
@patitonar
Copy link
Author

I refactored the solution. We go back to the initial 1.0.0-beta.30 version of web3 that used to work correctly. I added the modified version of web3-eth that includes getChainId on lib folder. After installing dependencies, this file overrides the one installed on node_modules.

I made more tests and with this changes and now the issue of false error of tx even if it was successful is now gone! So it seems that 1.0.0-beta.37 was causing that one too.

@akolotov akolotov merged commit e4153be into develop Mar 28, 2019
@ghost ghost removed the in progress label Mar 28, 2019
@akolotov akolotov removed the review label Mar 28, 2019
@akolotov akolotov deleted the add-own-web3 branch March 28, 2019 20:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 432

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 10.324%

Totals Coverage Status
Change from base Build 425: 0.03%
Covered Lines: 48
Relevant Lines: 443

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants