-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add own web3-eth version #205
Conversation
Deploy preview for kind-kilby-95344f processing. Building with commit fe27eba https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c9d2c416f5bc400088a6713 |
# Conflicts: # package-lock.json
I refactored the solution. We go back to the initial I made more tests and with this changes and now the issue of false error of tx even if it was successful is now gone! So it seems that |
This PR add web3 library inside the repo on
lib
directory. This web3 version is based on1.0.0-beta.37
and includesgetChainId
method onweb3-eth
module.preinstall
script was added to correctly build and include the web3 library as dependency for the app.Closes #204, using this version, we avoid the issues introduced before. While testing, only when I sent from ETC to ETH the false error of tx revert even if it was successful was present. So now we log the error but avoid stopping the UI flow