Use chainId instead of networkId #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Deploy preview for kind-kilby-95344f processing. Building with commit 86c1bfa https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c9bbcaff76f4c0007f31e3e |
akolotov
reviewed
Mar 27, 2019
Pull Request Test Coverage Report for Build 404
💛 - Coveralls |
patitonar
commented
Mar 27, 2019
| @@ -41,8 +41,9 @@ class TxStore { | |||
| this.getTxReceipt(hash) | |||
| }).on('error', (e) => { | |||
| if(!e.message.includes('not mined within 50 blocks') && !e.message.includes('Failed to subscribe to new newBlockHeaders')){ | |||
| this.alertStore.setLoading(false) | |||
| this.alertStore.pushError('Transaction rejected on wallet'); | |||
| // False error is thrown by web3 https://github.com/ethereum/web3.js/issues/2542 | |||
There was a problem hiding this comment.
@akolotov An issue from web3 it throwing error Error: Transaction has been reverted by the EVM: even if transaction was successful. The only workaround I found until it is fixed in a new version was to comment the code to stop the loading flow of the app when a transaction is submitted. The bad side is that if transaction is really reverted, the UI won't be notified
Closed
This was referenced Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
networkIdfor detecting on which network the user is, now we usechainId. For that I had to update to latest version ofweb3since there is a newgetChainIdmethod. I could use raw request to get thechainIdfor home and foreign networks, but I cannot access to the url used on the wallet, only by using the exposed web3 provider.For e2e tests I had to update the parity version. The e2e tests are failing, it seems an issue between the new web3 version we are using and the web3 version used by the metamask extension we are using on the test. I'll try to update the extension to a newer version.