Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETH Classic styles' changes #194

Closed
gabitoesmiapodo opened this issue Mar 26, 2019 · 3 comments
Closed

ETH Classic styles' changes #194

gabitoesmiapodo opened this issue Mar 26, 2019 · 3 comments
Assignees
@gabitoesmiapodo
Labels
enhancement New feature or request

Comments

@gabitoesmiapodo
Copy link

Updated design: https://zpl.io/2Gy5d09

  1. Change logo for all pages to

image

  1. 2 rows for networks

image (1)

Pasted_image_at_2019-03-25__11_38_PM

  1. Change old green color to new (only when background is white)

image (2)

Pasted_image_at_2019-03-25__11_39_PM

for all pages #2be187

  1. Change logo for ETH

image (3)

  1. Remove “2018 POA. All right reserved.”

image (4)
@gabitoesmiapodo gabitoesmiapodo added enhancement New feature or request in progress labels Mar 26, 2019
@gabitoesmiapodo gabitoesmiapodo self-assigned this Mar 26, 2019
@akolotov
Copy link
Collaborator

Are you sure that we should remove "2018 POA. All rights reserved." at all? Ziggy opened yesterday the PR where he changed the year label: #193

@gabitoesmiapodo
Copy link
Author

gabitoesmiapodo commented Mar 26, 2019 •
edited
Loading

It was requested by @igorbarinov

Not sure if it's only for this theme (ETH Classic) or all themes, though.

Maybe @SiddigZeidan and @igorbarinov can clarify?

@akolotov
Copy link
Collaborator

Thanks! Confirmed with @igorbarinov. We don't need this line at all. I will add a comment to Ziggy's PR.

gabitoesmiapodo added a commit that referenced this issue Mar 26, 2019
@gabitoesmiapodo
(fix) feedback on #194
aab6c61
@gabitoesmiapodo gabitoesmiapodo mentioned this issue Mar 26, 2019
Merged
@ghost ghost added the in progress label Mar 26, 2019
akolotov added a commit that referenced this issue Mar 27, 2019
@akolotov
Merge remote-tracking branch 'origin/develop' into fix/#194-ETH-class…
ff7b7f0 
…ic-styles-changes
akolotov added a commit that referenced this issue Mar 27, 2019
@akolotov
Merge pull request #195 from poanetwork/fix/#194-ETH-classic-styles-c…
622a801 
…hanges

(fix) Feedback on #194
@ghost ghost removed the in progress label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabitoesmiapodo gabitoesmiapodo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabitoesmiapodo @akolotov