Relax constraint on env_prefix when reading from environment #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauvilsa
requested changes
Jul 8, 2022
There was a problem hiding this comment.
Also please add a v4.11.0 (2022-07-??) section in the changelog with two entries, one in Added describing the new feature and another like
Lines 84 to 86 in 593dd78
mauvilsa
requested changes
Jul 8, 2022
mauvilsa
requested changes
Jul 8, 2022
mauvilsa
requested changes
Jul 11, 2022
Reading parameters from environment is a great feature, but user can sometimes want to not have any prefix when reading environment variables. This patch updates the property env_prefix to accept boolean, so that if set to True, if won't prefix the read environment variables.
|
Kudos, SonarCloud Quality Gate passed!
|
|
All tests/checks pass. But I'm not sure to understand why Windows 2019 test fail with
|
mauvilsa
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading parameters from environment is a great feature, but user
can sometimes want to not have any prefix when reading environement
variables.
This patch introduces another parameter named empty_env_prefix,
that if set to True, will initialize env_prefix to None, and hence unlock
what has been described above.