chore(contracts/solve): refactor order state #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
commented
Dec 19, 2024
| view | ||
| returns (ResolvedCrossChainOrder memory order, OrderState memory state, StatusUpdate[] memory history) | ||
| { | ||
| return (_orders[id], _orderState[id], _orderHistory[id]); | ||
| } |
There was a problem hiding this comment.
Struggled thinking of a more appropraite "wrapping" struct name. Everything felt forced. I actually think SolvertNetOrder is decent, in that a SolverNetOrder wraps a ResolvedCrossChainOrder
But didn't love that we us overloading the use of "order". And we just needed this to name a return type. Tuple should suffice, as this is view is mostly for off chain and easy to unpack.
Less terms == better
kevinhalliday
commented
Dec 19, 2024
| /** | ||
| * @dev Resolve the onchain order. | ||
| */ | ||
| function resolve(OnchainCrossChainOrder calldata order) external view returns (ResolvedCrossChainOrder memory); |
There was a problem hiding this comment.
Removed this as it was in ERC7683 intercace, which we inherit
kevinhalliday
commented
Dec 19, 2024
| /** | ||
| * @notice Returns the order parameters for the given order ID. | ||
| */ | ||
| function getOrderParams(bytes32 id) external view returns (SolverNetOrderParams memory); |
There was a problem hiding this comment.
removed view,s getOrder serves everything. can add back if we feel a need for it
Zodomo
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor order state types / logic.
SolverNetprefix to typenamesgetOrder, instead of forcing name on wrapped structissue: none