Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts/solve): implemented ERC7683 version of solve #2717

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

Zodomo
Copy link
Contributor

@Zodomo Zodomo commented Dec 17, 2024

Implemented an ERC7683 compliant version of the Solve contracts. No tests have been implemented yet at the time of this PR.

issue: #2691

@Zodomo Zodomo self-assigned this Dec 17, 2024
Copy link
Contributor

@kevinhalliday kevinhalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve and merge so we can start trunk-deving this guy.

struct Call {
bytes32 target;
uint256 value;
bytes callData;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO call prefix not needed, because struct is name Call, and instances likely named call.

so,

call.data 

// vs

call.callData

@kevinhalliday kevinhalliday merged commit bc045ed into main Dec 18, 2024
19 checks passed
@kevinhalliday kevinhalliday deleted the zodomo/erc7683-solve branch December 18, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants