feat(contracts/portal): refund xcall fee overpayment #2613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was a good suggestion. @kevinhalliday and I discussed and we decided that we will refrain from merging it for now. As it stands, integrating apps have to handle when users overpay as it is, so sending refunds to those apps seems to enforce not checking proper payment was made as a norm. Additionally, fee oracle updates are not frequent enough to cause user transactions to revert, so quotes should be accurate between a frontend retrieving one and a user's wallet submitting the transaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a refund on fee overpayment & made a small optimization that removes the second SSLOAD & is imo cleaner
Requesting feedback because there is a needless warning on unused low level return value