feat(sdk): init sdk package with biome and a precommit hook #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
approved these changes
Dec 2, 2024
sdk/src/utils/package.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "type": "module" | |||
| } | |||
There was a problem hiding this comment.
Why do we need these (this and src/types/package.json)?
There was a problem hiding this comment.
for the pnpm workspaces setup, the presence of each package.json indicates a new submodule within the workspace
sdk/pnpm-workspace.yaml
Outdated
| @@ -0,0 +1,2 @@ | |||
| packages: | |||
| - 'src' | |||
There was a problem hiding this comment.
I'm good with using a workspace but like we said live, might be best just to start with single package until we have need for multiple
There was a problem hiding this comment.
sounds good, i'll revert to a more simple setup
ga-reth
force-pushed
the
gv/init-sdk-dir
branch
from
d8afac1 to
9557257
Compare
|
hey @kevinhalliday i've dropped the workspaces stuff, and added compilation / clean steps, i'll add precommit stuff in a followup |
ga-reth
force-pushed
the
gv/init-sdk-dir
branch
from
9fb70b7 to
5b6b401
Compare
ga-reth
changed the title
|
@kevinhalliday i've added biome for linting/formatting and a precommit hook |
ga-reth
force-pushed
the
gv/init-sdk-dir
branch
from
4402595 to
e3fb674
Compare
ga-reth
force-pushed
the
gv/init-sdk-dir
branch
from
0676a53 to
595d627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialise the SDK package with:
issue: none