fix(relayer): include all applicable msgs in cursor store #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmllr
approved these changes
Nov 27, 2024
chmllr
pushed a commit
that referenced
this pull request
Dec 3, 2024
Wait for fuzzy submissions to finalize before confirming confFinalized streamers. This fixes the following issue - Fuzzy streamer is busy submitting some fuzzy messages (so msgCursorFilter has been updated). - Finalized streamer skips over them (filters them out) - Finalized streamer updates cursor store WITHOUT these fuzzy streams (BUG). - But fuzzy streamer doesn't actually submit messages (due to whatever reason). - When worker resets - Finalized streamer is ahead of fuzzy streamer and gets stuck and logs "Gap in fuzzy msg offsets". Solution - Include all applicable messages in cursor, not just submitted. - Finalized cursor will in that case not confirm, which is correct. issue: none
chmllr
pushed a commit
that referenced
this pull request
Dec 3, 2024
Wait for fuzzy submissions to finalize before confirming confFinalized streamers. This fixes the following issue - Fuzzy streamer is busy submitting some fuzzy messages (so msgCursorFilter has been updated). - Finalized streamer skips over them (filters them out) - Finalized streamer updates cursor store WITHOUT these fuzzy streams (BUG). - But fuzzy streamer doesn't actually submit messages (due to whatever reason). - When worker resets - Finalized streamer is ahead of fuzzy streamer and gets stuck and logs "Gap in fuzzy msg offsets". Solution - Include all applicable messages in cursor, not just submitted. - Finalized cursor will in that case not confirm, which is correct. issue: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for fuzzy submissions to finalize before confirming confFinalized streamers.
This fixes the following issue
Solution
issue: none