ci(e2e): support devnet chaos slashing #2489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
requested review from
sideninja,
chmllr,
kc1116 and
kevinhalliday
as code owners
corverroos
force-pushed
the
corver/chaosslash
branch
from
40079d3 to
1c18173
Compare
chmllr
approved these changes
Nov 15, 2024
| // This is used in production to disable chaos testing. | ||
| var noopChaos = func(context.Context, *abci.RequestFinalizeBlock) {} | ||
|
|
||
| const chaosSlashMinHeight = 10 |
There was a problem hiding this comment.
I'd appreciate a comment on why we want to skip the first 10 rounds if it's a real chaos testing?
|
closing in favour of cometbft InjectEvidence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support slash testing in e2e:
halo_chaos = truein e2e manifest.--devnet-chaos-test=trueflag in halo.The aim is to improve the edge-case testing when slashing occurs.
issue: none