Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): increase admin fb signing timeout #2464

Merged
merged 1 commit into from
Nov 12, 2024
Merged

chore(e2e): increase admin fb signing timeout #2464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/app/admin/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ func runForge(ctx context.Context, rpc string, input []byte, broadcast bool, sen
args = append(args, "--private-keys", strings.Join(dedup(anvilPks), ","))
} else {
// else, we use --unlocked flag, to send unsigned eth_sendTransaction requests
// with 5 minute timeout, to allow for fireblocks signing.
args = append(args, "--timeout", "300", "--unlocked")
// with 15 minute timeout, to allow for fireblocks signing.
args = append(args, "--timeout", "900", "--unlocked")
}

return execCmd(ctx, dir, "forge", args...)
Expand Down
2 changes: 1 addition & 1 deletion e2e/fbproxy/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func newHTTPServer(ctx context.Context, cfg Config) (*http.Server, error) {
return &http.Server{
ReadHeaderTimeout: 30 * time.Second,
IdleTimeout: 30 * time.Second,
WriteTimeout: 5 * time.Minute, // large timeout, to allow for fb tx mpc signing.
WriteTimeout: 15 * time.Minute, // large timeout, to allow for fb tx mpc signing.
Handler: http.HandlerFunc(proxy.Proxy),
}, nil
}
Expand Down
Loading