Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts/core): implemented solve outbox #2378

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

Zodomo
Copy link
Contributor

@Zodomo Zodomo commented Nov 4, 2024

Implemented initial solve Outbox and refactored as necessary in order to adequately test it.

issue: #2377

@Zodomo Zodomo self-assigned this Nov 4, 2024
@Zodomo Zodomo requested a review from kevinhalliday as a code owner November 4, 2024 23:25
@Zodomo
Copy link
Contributor Author

Zodomo commented Nov 4, 2024

Comprehensive testing of the Outbox is not yet finished as of this comment. I just wanted to push what I had so @kevinhalliday and I could sync and pivot if necessary.

Copy link
Contributor

@kevinhalliday kevinhalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why bindings all changed?

Actually maybe just need to regen. Looks like that check failed

contracts/core/src/solve/Inbox.sol Outdated Show resolved Hide resolved
contracts/core/src/solve/Outbox.sol Outdated Show resolved Hide resolved
contracts/core/src/solve/Inbox.sol Show resolved Hide resolved
contracts/core/src/solve/Outbox.sol Outdated Show resolved Hide resolved
contracts/core/src/solve/Inbox.sol Show resolved Hide resolved
contracts/core/src/solve/Outbox.sol Outdated Show resolved Hide resolved
@kevinhalliday
Copy link
Contributor

Comprehensive testing of the Outbox is not yet finished as of this comment. I just wanted to push what I had so @kevinhalliday and I could sync and pivot if necessary.

Feel free to add tests in additional PRs. In general let's try to keep PRs a bit smaller than we have done at this point

@kevinhalliday kevinhalliday self-requested a review November 5, 2024 16:50
@Zodomo Zodomo force-pushed the zodomo/solve-outbox branch from 54deb67 to 563e414 Compare November 5, 2024 18:12
@Zodomo
Copy link
Contributor Author

Zodomo commented Nov 5, 2024

Do we know why bindings all changed?

Actually maybe just need to regen. Looks like that check failed

I just tried reverting the changes to the allocs/bindings/golden files via rebase and pushed, however the action failed. When regenerating all of it, new versions are still produced. Not sure why it would fail when freshly regenerating everything.

Versions:

  • Go: 1.23.0
  • goreleaser: h1:/fSs+KwmCXCXN4eeI27z/xp1+FwIS4rWisL6aTUeiGw= (ModuleSum)
  • forge: 0.2.0 (9dbfb2f11)
  • pre-commit: 4.0.1

@kevinhalliday kevinhalliday merged commit 316ef69 into main Nov 5, 2024
18 checks passed
@kevinhalliday kevinhalliday deleted the zodomo/solve-outbox branch November 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants