-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts/core): implemented solve outbox #2378
Conversation
Comprehensive testing of the Outbox is not yet finished as of this comment. I just wanted to push what I had so @kevinhalliday and I could sync and pivot if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why bindings all changed?
Actually maybe just need to regen. Looks like that check failed
Feel free to add tests in additional PRs. In general let's try to keep PRs a bit smaller than we have done at this point |
54deb67
to
563e414
Compare
I just tried reverting the changes to the allocs/bindings/golden files via rebase and pushed, however the action failed. When regenerating all of it, new versions are still produced. Not sure why it would fail when freshly regenerating everything. Versions:
|
d3de18f
to
03efb61
Compare
Implemented initial solve Outbox and refactored as necessary in order to adequately test it.
issue: #2377