chore(e2e/app): DRAFT deploy contracts to test SILK against #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zodomo
requested review from
corverroos,
sideninja,
chmllr,
kc1116 and
kevinhalliday
as code owners
chmllr
reviewed
Nov 4, 2024
Comment on lines
+81
to
+88
| switch i { | ||
| case 0: | ||
| deployment.WstETH = addr | ||
| case 1: | ||
| deployment.RETH = addr | ||
| case 2: | ||
| deployment.METH = addr | ||
| } |
There was a problem hiding this comment.
Nit: this is a bit fragile. Do we need TokenDeployment to be a struct? Can it be a simple map, and then we simply do deployment[token.name] = addr?
There was a problem hiding this comment.
indeed, or something like:
token := struct {
setter func(common.Address)
..
}{
{
setter: func(addr common.Addrss) { deployment.WstETH = addr }
}
....
}
token.SetAddress(addr)
corverroos
reviewed
Nov 4, 2024
| deployment.METH = addr | ||
| } | ||
|
|
||
| log.Info(ctx, "Token deployed", |
There was a problem hiding this comment.
lets make this debug, info should only be main workflow steps, this is a sub-step
corverroos
reviewed
Nov 4, 2024
| } | ||
|
|
||
| func deploySymbioticVaults(ctx context.Context, def Definition, deployedTokens map[uint64]TokenDeployment) (map[uint64]SymbioticVaultDeployment, error) { | ||
| vaults := []string{ |
There was a problem hiding this comment.
suggest combining this and tokens above into a single package-level struct.
corverroos
changed the title
|
closed as this was more or less me just experimenting with the go codebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR seeking commentary on the Go I wrote. This is my first attempt at writing anything in Go, so I explicitly welcome criticism, feedback, and suggestions. Please let me know what you like, what you don't, and feel free to ask about why I did things certain ways if it is unclear.
issue: none