Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valsync buffering #2525

Closed
chmllr opened this issue Nov 21, 2024 · 0 comments
Closed

Valsync buffering #2525

chmllr opened this issue Nov 21, 2024 · 0 comments
Assignees

Comments

@chmllr
Copy link
Contributor

chmllr commented Nov 21, 2024

Implement #1857.

Corresponding ADR: https://www.notion.so/omni-network/Valsync-Buffering-14469a99643a809989a2e503733373e9

@chmllr chmllr self-assigned this Nov 21, 2024
@chmllr chmllr added this to the 1.2 - Valsync buffer [?] milestone Nov 21, 2024
chmllr added a commit that referenced this issue Nov 22, 2024
Add the boilerplate for a new Cosmos SDK module (step 1 of the Valsync
Buffering ADR).

issue: #2525
chmllr added a commit that referenced this issue Nov 22, 2024
…2543)

- rename proto type (singular <> plural)
- add stub `EvmEventProcessor` implementation for evmstaking2 keeper
- initialize the keeper
- add basic implementation for `Deliver`

issue: #2525
chmllr added a commit that referenced this issue Nov 25, 2024
- Introduce a new module parameter specifying the event submission
delay.
- Implement EndBlock, delivering all stored events after the configured
number of blocks.


issue: #2525
chmllr added a commit that referenced this issue Nov 25, 2024
Copies `Prepare` from `evmstaking` package and adds all the boilerplate
around it.

issue: #2525
chmllr added a commit that referenced this issue Nov 25, 2024
- Introduces a new method `processBufferedEvent` that clones the state
and tries to deliver the passed EVM event
- Integrates the implementation of `deliverDelegate` function from
`evmstaking` package

issue: #2525
chmllr added a commit that referenced this issue Nov 26, 2024
Integrates validator creation event delivery.

issue: #2525
chmllr added a commit that referenced this issue Nov 27, 2024
Implements the unit test for the delegate event delivery. At the end of
the test, we assert that the staking message server actually received
the message of the expected type.

issue: #2525
chmllr added a commit that referenced this issue Nov 27, 2024
Extends the unit test with delivery of validator creation event.

issue: #2525
chmllr added a commit that referenced this issue Dec 3, 2024
More unit tests for unhappy paths.

issue: #2525

---------

Co-authored-by: Khalil Claybon <[email protected]>
chmllr added a commit that referenced this issue Dec 6, 2024
Adds a new manifest and module wiring.

issue: #2525

---------

Co-authored-by: Khalil Claybon <[email protected]>
Co-authored-by: corver <[email protected]>
Co-authored-by: Zodomo <[email protected]>
chmllr added a commit that referenced this issue Dec 6, 2024
chmllr added a commit that referenced this issue Dec 9, 2024
- changes the delivered events metric to only go up if at least one
event was delivered
- adds a new interval for staging for easier testing

issue: #2525
chmllr added a commit that referenced this issue Dec 10, 2024
The current event processor seems to steal the EVM. We need to remove
the injection of the processor if the valsync buffering is on.

issue: #2525
chmllr added a commit that referenced this issue Dec 10, 2024
Validate EVM event processors and error on duplicate names or addresses.

issue: #2525
chmllr added a commit that referenced this issue Dec 12, 2024
Error on old code paths if a feature flag is set.

issue: #2525
@fabtreb fabtreb closed this as completed Dec 13, 2024
chmllr added a commit that referenced this issue Dec 13, 2024
Adds feature flags to the join test

issue: #2525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants