Skip to content

Commit

Permalink
remove githook logic and troubleshooting for commit sign
Browse files Browse the repository at this point in the history
  • Loading branch information
ga-reth committed Dec 3, 2024
1 parent e3fb674 commit 4335bb0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
9 changes: 2 additions & 7 deletions .pre-commit/run_sdk_checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,8 @@ SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
# nav to sdk dir
SDK_DIR="$SCRIPT_DIR/../sdk"

# when running pre-commit, files are passed as args
# when running git hook, find ourselves
if [ $# -eq 0 ]; then
TS_FILES=$(git diff --cached --name-only --diff-filter=ACMR | grep "^sdk.*\.\(ts\|tsx\)$" || true)
else
TS_FILES="$@"
fi
# get changed TS files
TS_FILES=$(git diff --cached --name-only --diff-filter=ACMR | grep "^sdk.*\.\(ts\|tsx\)$" || true)

if [ -n "$TS_FILES" ]; then
echo "Running SDK checks..."
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ Follow these steps to set up a functional development environment:
2a. [Create a PGP key pair](https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key)
2b. [Add the public key to Github](https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account).
2c. [Enabled commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
2d. [Troubleshoot any issues](https://gist.github.com/paolocarrasco/18ca8fe6e63490ae1be23e84a7039374)
3. Run `make setup` to initialize your dev environment. See `Makefile` for details.

## Security
Expand Down

0 comments on commit 4335bb0

Please sign in to comment.