This repository has been archived by the owner on Jan 21, 2021. It is now read-only.
Make itervar-values contained in sca- and vec-files available to R #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the commit in this pull request extends the
loadDataset
function such that the returned dataframe also includes the "itervar"-entries from the scalar/vector files, making it easier to group different runs by simulation parameter values.The code added to the
processLine
-method of theResultFileManager
-class is similar to the code regarding processing of run attributes. One rather subtle change is that I replaced the linePROTECT(dataset = NEW_LIST(9))
at the beginning of theexportDataset
-method in loadDataset.cc withPROTECT(dataset = NEW_LIST(datasetColumnsLength))
, as to me it seems that the "9" was just a hard-coded version of the number of dataset columns.I am also not familiar with writing R extensions and I am not sure if the call to
UNPROTECT(1)
is at the right place or if it should occur just after all the itervar entries have been added to the dataframe.Kind regards,
Martin