Add support for Metal arrays with MtlCellArray
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omlins
requested changes
Oct 10, 2024
There was a problem hiding this comment.
@albert-de-montserrat could you integrate the changes you did in your PR that didnt fully work unfortunately in the tests concerning the float type?
|
@omlins requested changes in tests have been implemented, requesting another review. |
omlins
requested changes
Oct 14, 2024
Nice catch! Should be fixed now. |
|
Thanks @GiackAloZ and @albert-de-montserrat ! |
|
The CI fails for Windows and MacOS: Merged nevertheless into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Metal arrays in CellArray.jl, introducing the type
MtlCellArraysimilarly to other GPUArrays.jl compatible backends.