fix(validate): only accept leading digit or v character

omichelsen · Dec 10, 2021 · bac8066 · bac8066
1 parent 0fc5477
commit bac8066
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/index.mjs b/index.mjs
@@ -21,7 +21,8 @@ export default function compareVersions(v1, v2) {
   return 0;
 }
 
-export const validate = (v) => typeof v === 'string' && semver.test(v);
+export const validate = (v) =>
+  typeof v === 'string' && /^[v\d]/.test(v) && semver.test(v);
 
 export const compare = (v1, v2, operator) => {
   // validate input operator

diff --git a/test/validate.mjs b/test/validate.mjs
@@ -9,6 +9,7 @@ describe('validate versions', () => {
     [{}, false],
     [[], false],
     [() => undefined, false],
+    ['foo', false],
     ['6.3.', false],
     ['1.2.3a', false],
     ['1.2.-3a', false],
@@ -21,6 +22,8 @@ describe('validate versions', () => {
     ['1.0.0+20130313144700', true],
     ['1.2.3.100', true],
     ['2020', true],
+    ['=1.0', false],
+    ['>1.0.0', false],
   ].forEach(([v, expected]) => {
     it(`${v}`, () => {
       assert.equal(validate(v), expected);