refactor: speed up finalizes current forming block and inserts new on…

…e if transaction limit for a block is reached test
omgnetwork · Oct 9, 2020 · c23be95 · c23be95
1 parent d3c7567
commit c23be95
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/apps/engine/test/engine/callbacks/deposit_test.exs b/apps/engine/test/engine/callbacks/deposit_test.exs
@@ -1,7 +1,7 @@
 defmodule Engine.Callbacks.DepositTest do
   @moduledoc false
 
-  use Engine.DB.DataCase, async: true
+  use Engine.DB.DataCase, async: false
 
   alias Engine.Callbacks.Deposit
   alias Engine.DB.ListenerState

diff --git a/apps/engine/test/engine/db/transaction_test.exs b/apps/engine/test/engine/db/transaction_test.exs
@@ -184,12 +184,11 @@ defmodule Engine.DB.TransactionTest do
       assert expected_position == actual_positions
     end
 
-    @tag timeout: :infinity
-    @tag :integration
     test "finalizes current forming block and inserts new one if transaction limit for a block is reached" do
       block = insert(:block)
 
-      _ = Enum.map(1..@max_txcount, fn index -> insert(:payment_v1_transaction, %{block: block, tx_index: index}) end)
+      # we determine number of transactions in a block by querying for max transaction index in the block
+      _ = insert(:payment_v1_transaction, %{block: block, tx_index: @max_txcount})
 
       tx_bytes = transaction_bytes()
       {:ok, %{transaction: transaction}} = Transaction.insert(tx_bytes)