fix: observe GRPC client #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gab-arrobo
reviewed
Oct 21, 2024
There was a problem hiding this comment.
I see that changes are not consistent across the different NFs (in some NFs the updateConfig is in service/init.go like this in NF/PR and in other NFs, the same function goes in factory/factory.go). Would this be a good time to make the change consistent across all NFs?
I will move the implementation to under service/init. |
gatici
force-pushed
the
TELCO-1381-observe-grpc-client
branch
2 times, most recently
from
26e1312 to
4fa3dfc
Compare
|
@gatici do not forget to rebase your branch |
gatici
force-pushed
the
TELCO-1381-observe-grpc-client
branch
15 times, most recently
from
088408f to
d1e3a1d
Compare
gab-arrobo
reviewed
Oct 26, 2024
gab-arrobo
reviewed
Oct 28, 2024
There was a problem hiding this comment.
@gatici, did you have a chance to verify these changes with an E2E test? I am asking this because my E2E tests fail when using this PR, as you can see below:
"Profile Name: profile7 , Profile Type: uereqpdusessrelease",
"Ue's Passed: 0 , Ue's Failed: 5",
"Profile Errors:",
"imsi:imsi-208930100007563, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007561, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007564, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007560, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007562, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"Profile Status: FAIL",
"Profile Name: profile2 , Profile Type: pdusessest",
"Ue's Passed: 0 , Ue's Failed: 5",
"Profile Errors:",
"imsi:imsi-208930100007513, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007512, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007511, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007514, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007510, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"Profile Status: FAIL",
"Profile Name: profile4 , Profile Type: uetriggservicereq",
"Ue's Passed: 0 , Ue's Failed: 5",
"Profile Errors:",
"imsi:imsi-208930100007534, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007533, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007532, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007531, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007530, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"Profile Status: FAIL",
"Profile Name: profile3 , Profile Type: anrelease",
"Ue's Passed: 0 , Ue's Failed: 5",
"Profile Errors:",
"imsi:imsi-208930100007522, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007524, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007523, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007520, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007521, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"Profile Status: FAIL",
"Profile Name: profile1 , Profile Type: register",
"Ue's Passed: 0 , Ue's Failed: 5",
"Profile Errors:",
"imsi:imsi-208930100007504, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007501, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007503, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007500, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007502, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"Profile Status: FAIL",
"Profile Name: profile5 , Profile Type: deregister",
"Ue's Passed: 0 , Ue's Failed: 5",
"Profile Errors:",
"imsi:imsi-208930100007541, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007543, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007544, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007540, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"imsi:imsi-208930100007542, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT",
"Profile Status: FAIL"
Yes, tested and it is all passing. |
I am still getting the same errors as before (all profiles fail to pass the E2E tests). How should we proceed about this? |
|
Hello @gab-arrobo Could you please check the logs of other NF's ? Especially AMF, AUSF and UDM ? There can be something wrong with the other |
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
gatici
force-pushed
the
TELCO-1381-observe-grpc-client
branch
from
06d3c21 to
5a55120
Compare
Done |
gab-arrobo
requested changes
Nov 5, 2024
Signed-off-by: gatici <[email protected]>
gab-arrobo
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve GPRC client connection issues which appears when GPRC server (webconsole) is restarted.
If the Webconsole is restarted, other modules loses the GRPC connection to Webconsole
They tries to connect again for hours with no success.
2024-09-26T11:32:10.014Z [smf] 2024-09-26T11:32:10Z [ERRO][Config5g][GRPC] Connectivity status idle, trying to connect again
NF observes the GRPC client availability and connection status in an infinite loop.
If the connection is ready it does nothing. If GRPC client does not exist, it creates new client. If GRPC client connection is not ready, it closes the existing client and creates another client.
Only one GRPC client exists for any time slot.