Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

60-database.sh: Support omero.db.port #20

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Conversation

joshmoore
Copy link
Member

When running on a non-standard port, it's currently
necessary to create a redirect image using socat in
order to have the database upgraded. Longer-term it
may be easier to delegate this logic to pgpass.

When running on a non-standard port, it's currently
necessary to create a redirect image using socat in
order to have the database upgraded. Longer-term it
may be easier to delegate this logic to pgpass.
@manics
Copy link
Member

manics commented Mar 5, 2018

What are your thoughts on the structure of the config in this image? Is the combination of env-vars + support for config files (and the interdependency between them) a problem e.g. as in #17? Should it be modified or completely refactored? Or do you think it's an acceptable compromise?

@joshmoore
Copy link
Member Author

I understand what you mean from the other PR that this is getting somewhat unclean, but I don't have a clear idea of how we would fix it. If you have something you've been wanting to see happen, happy to have it spelled out. (Sorry if I'm missing something)

At the moment, I do think that this and gh-17 are somewhat acceptable compromises, or at least, I would much prefer to not wait on a breaking change since I'm now working around in various places:

  redirect:
    build: redirect
FROM centos:centos7
RUN yum install -y socat
ENTRYPOINT socat TCP-LISTEN:5432,fork TCP:host:5433

which is not a nicer compromise.

60-database.sh Outdated Show resolved Hide resolved
@manics manics mentioned this pull request Dec 7, 2020
@manics manics closed this Dec 7, 2020
@manics manics reopened this Dec 7, 2020
@manics manics closed this Dec 7, 2020
@manics manics reopened this Dec 7, 2020
@manics manics merged commit 288e63d into ome:master Dec 7, 2020
@joshmoore joshmoore deleted the port-config branch December 7, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants