-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support filtering by OMERO.tables on Dataset #86
base: master
Are you sure you want to change the base?
Conversation
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/using-omero-parade-on-dataset-level-and-image-level-omero-tables/50180/2 |
One RFE, #86 (comment) which might be for another PR. I went over just checking the filtering and added values from the table to columns. Except #86 (comment) I noticed also that the graph autoformat of axes does not seem right |
The filtering works fine, happy for the RFEs #86 (comment) to be fixed in a follow-up PR. |
The plot axis issue (#86 (comment)) is probably due to the fact that I used the OMERO.table for the whole Project, and just linked it to one Dataset for this test. So it has Image IDs in the table that are causing the min/max range of Image IDs to extend beyond those that are in this Dataset. |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/using-omero-parade-on-dataset-level-and-image-level-omero-tables/50180/6 |
As seen from #90, users are trying to filter images on a Dataset which has attached csv/tables. In this case, the Dataset is an orphan. |
Avoid conflict with #122 --exclude |
See https://forum.image.sc/t/using-omero-parade-on-dataset-level-and-image-level-omero-tables/50180
This fixes a limitation of not supporting OMERO.table filtering on Datasets.
To test: