Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filtering by OMERO.tables on Dataset #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Mar 16, 2021

See https://forum.image.sc/t/using-omero-parade-on-dataset-level-and-image-level-omero-tables/50180

This fixes a limitation of not supporting OMERO.table filtering on Datasets.

To test:

$ omero obj new DatasetAnnotationLink parent=Dataset:151 child=FileAnnotation:3774 
  • I also made the Dataset an Orphan, by removing it from the Project.
  • Then you can choose the Dataset alone in OMERO.parade and filter -> Table

Screenshot 2021-03-16 at 11 50 19

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/using-omero-parade-on-dataset-level-and-image-level-omero-tables/50180/2

@pwalczysko
Copy link
Member

I guess there would be a case for not showing the Show Datasets checkbox if youi are working only on one dataset ?

Screenshot 2021-03-18 at 16 23 27

@pwalczysko
Copy link
Member

One RFE, #86 (comment) which might be for another PR. I went over just checking the filtering and added values from the table to columns. Except #86 (comment) I noticed also that the graph autoformat of axes does not seem right

Screenshot 2021-03-18 at 16 27 54

@pwalczysko
Copy link
Member

The filtering works fine, happy for the RFEs #86 (comment) to be fixed in a follow-up PR.

@will-moore
Copy link
Member Author

The plot axis issue (#86 (comment)) is probably due to the fact that I used the OMERO.table for the whole Project, and just linked it to one Dataset for this test. So it has Image IDs in the table that are causing the min/max range of Image IDs to extend beyond those that are in this Dataset.
So, I think we can ignore this unless we know of workflows where this would routinely be a problem.

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/using-omero-parade-on-dataset-level-and-image-level-omero-tables/50180/6

@will-moore
Copy link
Member Author

As seen from #90, users are trying to filter images on a Dataset which has attached csv/tables. In this case, the Dataset is an orphan.

@will-moore
Copy link
Member Author

Avoid conflict with #122

--exclude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants