Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OMEZarrReader to 0.5.2 #6

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

dgault
Copy link
Member

@dgault dgault commented Aug 7, 2024

Bumping version of ZarrReader to 0.5.2

The bioformats2raw dependency included in the build.gradle is only included as a test dependency so I don't believe this requires a version bump. Looking at the code I also don't think that dependency is actually being used for an actual test at the minute and could likely be removed completely along with the 1 test method using it.

@khaledk2, I don't believe there is any other dependencies for Bio-Fromats or Omero included here that require a version bump, is that correct?

@khaledk2
Copy link
Collaborator

khaledk2 commented Aug 7, 2024

@dgault I think loci.formats.FormatTools is a Bio-Format package and it is used in many classes, e.g.


Am I correct?

@dgault
Copy link
Member Author

dgault commented Aug 7, 2024

Yeah, I am assuming that is being brought in via OMERO blitz, so that would need bumped also

@melissalinkert
Copy link
Member

Likely outside the scope of this PR, but FYI https://github.com/glencoesoftware/bioformats2raw/releases/tag/v0.9.4 was just released and includes Bio-Formats 7.3.1.

The following suggest that bioformats2raw is actively used in the tests:

@dgault
Copy link
Member Author

dgault commented Aug 9, 2024

In that case bumping to the latest bioformats2raw would make most sense and keep everything aligned

@sbesson sbesson requested review from sbesson and khaledk2 August 12, 2024 09:34
@khaledk2 khaledk2 merged commit 00e8440 into ome:master Aug 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants