Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand release #5

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Expand release #5

merged 2 commits into from
Jul 22, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Jul 17, 2024

This PR

  • add the java version to the name of the zip/tar
  • attaches all the artifacts to the release

@jburel jburel requested a review from khaledk2 July 17, 2024 12:43
@jburel
Copy link
Member Author

jburel commented Jul 18, 2024

@khaledk2
Copy link
Collaborator

I think the folder name inside the compressed file should have the same name as the file.
For example, the folder should be \omero-ms-image-region-0.10.0_11 inside \omero-ms-image-region-0.10.0_11.zip
it is now \omero-ms-image-region-0.10.0

@jburel
Copy link
Member Author

jburel commented Jul 18, 2024

That will mean unzipping, changing the name and re-zipping. This not what is currently done during the build process i.e. see for example https://github.com/ome/omero-ms-image-region/actions/runs/9954646655, check the folder name and the zip name.
The appended version is mainly to make sure that one selects the zip matching the Java version installed.

@khaledk2
Copy link
Collaborator

This should be fine, but we should update ome/ansible-role-omero-ms-image-region#4 to account for that.

@jburel jburel merged commit e41eaaa into ome:master Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants