Prep idr #4
Prep idr #4
Conversation
There was a problem hiding this comment.
From a quick investigation on the VMs, all the testing that happened lately on test122 was done with a version of the micro-service derived from the upstream omero-ms-image-region 0.8.7. The latest pulls on the development branch of this fork include the changes from the latest omero-ms-image-region 0.10.0 release and this PR adds the OMEZarrReader 0.5.1 dependency used by IDR as well as a deployment step.
From a code review perspective, the dependency change look good from my side and should allow to build a bundle of the micro-service with the required Bio-Formats dependencies. One inline question about the intent of the deployment mechanism and the coordinates under which the artifact should be published.
In terms of functional testing, do you also anticipate the spin-up of a new idr-testing environment where this build can be deployed and tested?
|
commit 59df744 tested via personal account |
Replaces PR #3
cc @pwalczysko
The main question is around the publication strategy