Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot #30

Merged
merged 4 commits into from
May 13, 2021
Merged

Screenshot #30

merged 4 commits into from
May 13, 2021

Conversation

jburel
Copy link
Member

@jburel jburel commented May 13, 2021

  • Add screenshot to the notebook
  • Check that you can run the notebook. The first cell loading the library should be enough since it highlights the problem due itkwidgets

cc @pwalczysko

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch screenshot

"cell_type": "markdown",
"metadata": {},
"source": [
"![Compare](images/ilastik_1.png)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see that screenshot in the rendered notebook. Is that maybe not added ? Do not see that png added in the diff of the PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to push the images
Done

@pwalczysko
Copy link
Member

@pwalczysko
Copy link
Member

pwalczysko commented May 13, 2021

Thank you, the screenshots are there now.
If I may suggest not taking the top part of the dock in Mac for ilastik_1.png though

Screenshot 2021-05-13 at 16 06 54

Also, in the meantime, I have a repeated error when built locally.

Pip subprocess error:
ERROR: Could not install packages due to an EnvironmentError: [Errno 28] No space left on device: '/tmp/pip-install-ef5bu1zn/itk-filtering'



CondaEnvException: Pip failed

I have 112 GB free space on my Mac, so not sure why is this happening.

Edit:
Trying now after cleanup with
docker image prune -a

@jburel
Copy link
Member Author

jburel commented May 13, 2021

you will need to clear space
docker system prune
and
docker image prune -a

@pwalczysko
Copy link
Member

you will need to clear space
docker system prune
and
docker image prune -a

@jburel Thank you, that worked, also locally the notebook is running without problems now.

The screenshot improvement looks good as well.

Ready to merge fmpov

@jburel jburel merged commit 57cfae0 into ome:master May 13, 2021
@jburel jburel deleted the screenshot branch August 11, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants