Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version #29

Merged
merged 8 commits into from
Apr 30, 2021
Merged

Bump version #29

merged 8 commits into from
Apr 30, 2021

Conversation

jburel
Copy link
Member

@jburel jburel commented Apr 29, 2021

This PR bumps the version of ilastik and uses the meta-package.
This is the only way I managed to get it to work again
h5py is capped otherwise it does not work with binder
The way the input array is passed has been modified in both scripts and notebooks
cc @pwalczysko

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch bump_version

@joshmoore
Copy link
Member

Did h5py drop support or break an API or something?

@jburel
Copy link
Member Author

jburel commented Apr 29, 2021

No this is due to mamba that is used during the build process by repo2docker
see h5py/h5py#1880

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basic changes all look good. 👍 (Obviously, ipynb diffs are always a bit problematic.)

@pwalczysko
Copy link
Member

pwalczysko commented Apr 30, 2021

MyBinder, idr0062_pixel_classification_zarr.ipynb notebook

Error loading notebook

Unreadable Notebook: /home/jovyan/notebooks/idr0062_pixel_classification_zarr.ipynb NotJSONError('Notebook does not appear to be JSON: \'{\\n "cells": [\\n {\\n "cell_type": "m...')

Repeated this error also locally - repo2docker

@jburel
Copy link
Member Author

jburel commented Apr 30, 2021

thanks @pwalczysko. I was cleaning the notebooks and probably cleaned too much :-)

@pwalczysko
Copy link
Member

the other two notebooks worked fine.

@jburel
Copy link
Member Author

jburel commented Apr 30, 2021

@pwalczysko it should be fixed now

@pwalczysko
Copy link
Member

@pwalczysko it should be fixed now

Yes, tested on MyBinder, and the notebook works as expected now.
Interestingly, I noticed a warning (see screenshot below).

Screenshot 2021-04-30 at 17 06 22

Looks good to me.

@jburel
Copy link
Member Author

jburel commented Apr 30, 2021

Merging.
I will push a new tag and update the value in itr
cc @sbesson

@jburel jburel merged commit c5851a8 into ome:master Apr 30, 2021
@jburel jburel deleted the bump_version branch August 11, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants