Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to RTD #2198

Closed
8 of 10 tasks
jburel opened this issue Dec 3, 2021 · 18 comments
Closed
8 of 10 tasks

Migration to RTD #2198

jburel opened this issue Dec 3, 2021 · 18 comments

Comments

@jburel
Copy link
Member

jburel commented Dec 3, 2021

List of tasks for the migration to RTD

@jburel
Copy link
Member Author

jburel commented Dec 3, 2021

Source https://docs.readthedocs.io/en/stable/faq.html

How do I change my project slug (the URL your docs are served at)?¶
We don’t support allowing folks to change the slug for their project. You can update the name which is shown on the site, but not the actual URL that documentation is served.

The main reason for this is that all existing URLs to the content will break. You can delete and re-create the project with the proper name to get a new slug, but you really shouldn’t do this if you have existing inbound links, as it breaks the internet.

If that isn’t enough, you can request the change sending an email to [email protected].

How do I change the version slug of my project?¶
We don’t support allowing folks to change the slug for their versions. But you can rename the branch/tag to achieve this. If that isn’t enough, you can request the change sending an email to [email protected].

@jburel jburel mentioned this issue May 2, 2022
@jburel
Copy link
Member Author

jburel commented May 26, 2022

@pwalczysko
Copy link
Member

Looks very nice !

@jburel
Copy link
Member Author

jburel commented May 27, 2022

I have added a rule so a dedicated version is automatically built when a tag is pushed
see for example https://omero.readthedocs.io/en/v5.6.4-2/

@sbesson
Copy link
Member

sbesson commented May 30, 2022

Is the plan to enable rtd on pull requests (similar to the guides for instance)? If so, does this make https://github.com/ome/omero-documentation/blob/develop/.github/workflows/sphinx.yml effectively redundant ?

@jburel
Copy link
Member Author

jburel commented May 30, 2022

It should be enabled on pull requests, so yes the job will be redundant

@jburel
Copy link
Member Author

jburel commented Jun 29, 2022

Redirect options

As discussed asynch in slack, until we switch to 6,

@sbesson
Copy link
Member

sbesson commented Jun 29, 2022

From a quick look, .htaccess seem to do the job for redirecting /omero/XXX URLs to another domain including deep link redirects.

A few questions:

https://docs.openmicroscopy.org/omero/5.6.x/ -> https://omero.readthedocs.io/en/v5.6.x/

For instance, we already published https://omero.readthedocs.io/en/v5.6.5-1/ with minor modifications. Does this mean this link will need to keep evolving every time we make a rtd release?

https://docs.openmicroscopy.org/omero/latest -> https://omero.readthedocs.io/en/stable/
https://docs.openmicroscopy.org/omero/5 -> https://omero.readthedocs.io/en/stable/ or https://omero.readthedocs.io/en/v5.6.x/

What about retaining the existing logic and have
https://docs.openmicroscopy.org/omero/latest -> https://docs.openmicroscopy.org/omero/5.6.5 -> https://omero.readthedocs.io/en/v5.6.x/ ?

I assume some links will need to be updated on every OMERO.server release anyways?

@jburel
Copy link
Member Author

jburel commented Jun 29, 2022

@sbesson
Copy link
Member

sbesson commented Jun 29, 2022

i.e. each time we do a doc update we will need to update the redirect

So you would not update https://docs.openmicroscopy.org/omero/5.6.5 when a new 5.6.5-z tag is pushed to this repository either ? That's the least amount of maintenance but we need to be comfortable with the fact that our redirects might point to outdated readthedocs versions.

@sbesson
Copy link
Member

sbesson commented Jun 29, 2022

Also sharing the configuration for the redirection which is pretty simple

[sbesson@idr0-slot3 5.6.5]$ cat .htaccess 
Redirect 301 /omero/5.6.5 https://omero.readthedocs.io/en/v5.6.5-1/

@jburel
Copy link
Member Author

jburel commented Jun 29, 2022

i.e. each time we do a doc update we will need to update the redirect

So you would not update https://docs.openmicroscopy.org/omero/5.6.5 when a new 5.6.5-z tag is pushed to this repository either ? That's the least amount of maintenance but we need to be comfortable with the fact that our redirects might point to outdated readthedocs versions.

There's a banner indicating that there's a new version of you are looking at the most recent tag for example go to v5.6.5 so I don't think it will be a problem

@sbesson
Copy link
Member

sbesson commented Jun 29, 2022

The proposal from #2198 (comment) is now implemented and should redirect both the top-level and the deep links

[sbesson@idr0-slot3 omero]$ cat 5.6.5/.htaccess 
Redirect 301 /omero/5.6.5 https://omero.readthedocs.io/en/v5.6.5/
[sbesson@idr0-slot3 omero]$ cat 5.6/.htaccess 
Redirect 301 /omero/5.6 https://omero.readthedocs.io/en/stable/
[sbesson@idr0-slot3 omero]$ cat 5/.htaccess 
Redirect 301 /omero/5 https://omero.readthedocs.io/en/stable/
[sbesson@idr0-slot3 omero]$ cat latest/.htaccess 
Redirect 301 /omero/latest https://omero.readthedocs.io/en/stable/

No immediate objection to moving with this approach and possibly revisiting later but I'll leave others who have been updating the technical documentation to review /cc @joshmoore @pwalczysko

@sbesson
Copy link
Member

sbesson commented Jun 30, 2022

Another issue I noticed while posting the URLs to the documentation is that the documentation title currently reads as

OMERO Documentation version 5.6 - OMERO 5.6.5-SNAPSHOT-1 documentation

I assume this comes from

version = "5.6.5-SNAPSHOT-1"
. Are we still expecting to manage this version by hand in addition to the tag?

@jburel
Copy link
Member Author

jburel commented Jun 30, 2022

I think we should try to automate that.
I will check

@jburel
Copy link
Member Author

jburel commented Jul 4, 2022

I have made the release process section more visible see #2260

@jburel
Copy link
Member Author

jburel commented Jul 5, 2022

Explanation of one cancelled job when the tag is pushed readthedocs/readthedocs.org#8015 (comment)

@sbesson
Copy link
Member

sbesson commented Jul 4, 2023

Assuming this can be closed?

@jburel jburel closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants