-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download via rawpixelsstore #1
Conversation
I need to install bioformats2raw to test that this all still works as before. |
Would it be easier to create an official OME 'omero-cli-zarr' repository from scratch and just use the rawpixelstore approach for that? 'bioformats2raw' isn't actually needed then. This repository was just an attempt to play around with it a little bit, and is probably unneccessary now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments but good to have this somewhere reusable.
parser.add_argument("--tile_height", default=None) | ||
parser.add_argument("--resolutions", default=None) | ||
parser.add_argument("--max_workers", default=None) | ||
ProxyStringType("Image") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be removed, no?
@@ -0,0 +1,106 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this file probably isn't conflict-safe enough.
|
||
parser.add_argument("--bf", action="store_true", | ||
help="Use bioformats2raw to read from managed repo") | ||
parser.add_argument("--tile_width", default=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These might also be of use for the numpy version.
"--cache_numpy", action="store_true", | ||
help="Save planes as .npy files in case of connection loss") | ||
|
||
parser.add_argument("--bf", action="store_true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see naming this --local
and pass it the ManagedRepository
location directly.
Merging. I'll try to handle Josh's remarks myself in a follow-up PR. Passing in the ManagedRepository location as argument is definitely a good idea! |
img_group named image.getName() added to collection
Ported the script from https://github.com/ome/omero-ms-zarr/blob/master/src/scripts/omero_to_zarr.py and updated with omero metadata
To test:
Also test the other arguments mentioned in the README (
--output
and--cache_numpy
).Use napari and the https://github.com/ome/ome-zarr-py to open in napari:
To export with bioformats2raw, use the
--bf
flag.