Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bioformats layout #13

Merged
merged 12 commits into from
Sep 28, 2022
Merged

Bioformats layout #13

merged 12 commits into from
Sep 28, 2022

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Sep 9, 2022

For a bioformats2raw.layout, load the OME/METADATA.xml and show image names, with links to browse to them.

WIP:

Screenshot 2022-09-09 at 17 19 58

@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for ome-ngff-validator ready!

Name Link
🔨 Latest commit 9a4d3a9
🔍 Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/63341a1760e9af000934ad1a
😎 Deploy Preview https://deploy-preview-13--ome-ngff-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@will-moore
Copy link
Member Author

@joshmoore Fixed links (and I ignore Bioformats2raw layout for plates).
Also, added a vizarr link to each Image

Screenshot 2022-09-15 at 13 14 39

@joshmoore
Copy link
Member

Also, added a vizarr link to each Image

That's a good idea for working around hms-dbmi/vizarr#149 👍

@will-moore will-moore marked this pull request as ready for review September 20, 2022 11:48
broken by earlier css change that caused parent.offsetLeft to give different value
@joshmoore
Copy link
Member

Any other changes expected here, @will-moore ?

@will-moore
Copy link
Member Author

No, I'm not planning to add anything else

@joshmoore
Copy link
Member

Propose to release tomorrow as 0.3.0 along with ome/ngff#112 (review)

@will-moore
Copy link
Member Author

@joshmoore I updated version to 0.3.0 and updated changelog

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/intermission-ome-ngff-0-4-1-bioformats2raw-0-5-0-et-al/72214/1

@will-moore will-moore merged commit 4041dee into ome:main Sep 28, 2022
@will-moore
Copy link
Member Author

@joshmoore it looks like something's gone wrong with the deploy as https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.3/9836842.zarr is not showing this PR.
The netlify build is OK https://ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.3/9836842.zarr but deploy to gh-pages isn't?

Will look more tomorrow....

@joshmoore
Copy link
Member

Think it's just missing the tag. I'll add one now.

@joshmoore
Copy link
Member

I take it back. That didn't trigger anything additional; it does look like the deployments just didn't run...

@joshmoore
Copy link
Member

Your merge here looks to have triggered the gh-pages branch to be updated:

https://github.com/ome/ome-ngff-validator/tree/gh-pages

but that didn't trigger a job for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants