-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XMLMockObjects: make artificial SHA1 schema-compliant #158
Conversation
To my original surprise, this change failed the unit tests in https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-image/1151 with the following validation error
After some investigation, I suspect the explanation is that the ome-model/specification/src/main/resources/released-schema/2016-06/ome.xsd Lines 1467 to 1476 in e6efb88
So the 20 length restriction might not apply to the hexadecimal string but rather to its equivalent binary representation. This matches what Python
|
Using a 40 character string passes Java tests and fails Python tests. Using a 20 character string passes Python tests but fails Java tests.
Following today's formats team discussion, removing The longer-term solution is to update the schema to deprecate |
While trying to get the `bioformats2raw.layout` specification (ome/ngff#112) this raised its head again. Following the discussion in ome/ome-model#158 changing the size checks to `40` passes. fix: ome/bioformats#3810 fix: ome/napari-ome-zarr#47 (comment)
* Update Hex40 definition While trying to get the `bioformats2raw.layout` specification (ome/ngff#112) this raised its head again. Following the discussion in ome/ome-model#158 changing the size checks to `40` passes. fix: ome/bioformats#3810 fix: ome/napari-ome-zarr#47 (comment) * Bump to min_length=40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original issue associated with the reading the Plane.HashSHA1 has been fixed downstream - see e.g. tlambert03/ome-types#146.
As discussed at the Formats meeting, a secondary problem is that the Plane.HashSHA1 carries the expectation to store a hash of the plane data. At the moment, this mock infrastructure will unconditionally store an arbitrary value which has the potential to create confusion for downstream consumers.
Given all the builds have been staying green with this PR included, I would agree to get it merged and included in the next ome-model release.
See ome/bioformats#3810