-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: move to RTD #177
Conversation
Automated Review URLs |
Looks nice! 👍 |
Is it right that this could help divide "strictly spec" from "spec-adjacent" (e.g. examples) to different pages? Hopefully resulting in a less cluttered spec? |
From my POV, that's certainly an option, sure. An additional next step that could go in the description of this PR but I didn't really want to get in is that we could drop bikeshed in favor of some flavor of plain markdown. That might make it easier to refactor more readily in this repo. |
Ok, I think that includes all the "must-fix" items. Biggest question remaining in my mind is whether or not to set the
If we do that, then once DNS is re-directed, all previous URLs should continue working. |
Discussing during the "Zarr Resources" call with @will-moore and @pwalczysko, we're going to merge this and drop the |
Proposal: move to RTD SHA: 82152e3 Reason: push, by @joshmoore Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ome/ngff: https://ngff.openmicroscopy.org/data/ is now live with a DNS entry to readthedocs.io |
This branch contains the necessary bootstrapping to deploy the specifications as well as other sphinx pages on https://readthedocs.org:
conf.py
runs bikeshed which is copied viahtml_extra_path
index.rst
redirects to latest/index.html as beforeabout/index.md
is available as a new top-level landing pageThis was largely done in order to provide the ngff.openmicroscopy.org/tools and ngff.openmicroscopy.org/data URLs as decided in theOME-Zarr preprint:
tools/index.rst
is largely done and driven bylists.csv
(but could look nicer)data/index.md
is a simple but linked table at the momentpublications/index.md
has been added but is still unpopulatedThe current branch can be reviewed at https://ngff.readthedocs.io/en/rtd/about/index.html . Once this PR is merged, https://ngff.readthedocs.io/en/latest/about/index.html would become a new default landing location without further configuration and the URLs needed can redirect to, e.g., https://ngff.readthedocs.io/en/latest/tools/
We should likely consider renaming the sphinx-specific
latest
to not conflict with the spec-specificlatest
, otherwise we get a default URL of https://ngff.readthedocs.io/en/latest/latest/index.html . If there's a general consensus, we could also redirecthttps://ngff.openmicroscopy.org
away from GitHub pages and tohttps://ngff.readthedocs.io
. Additionally, we can drop the redirect tolatest/index.html
in favor of a top-level landing page likeabout/index.md
.TODOS: