Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: move to RTD #177

Merged
merged 19 commits into from
Apr 21, 2023
Merged

Proposal: move to RTD #177

merged 19 commits into from
Apr 21, 2023

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore commented Mar 14, 2023

This branch contains the necessary bootstrapping to deploy the specifications as well as other sphinx pages on https://readthedocs.org:

  • conf.py runs bikeshed which is copied via html_extra_path
  • index.rst redirects to latest/index.html as before
  • about/index.md is available as a new top-level landing page

This was largely done in order to provide the ngff.openmicroscopy.org/tools and ngff.openmicroscopy.org/data URLs as decided in theOME-Zarr preprint:

  • tools/index.rst is largely done and driven by lists.csv (but could look nicer)
  • data/index.md is a simple but linked table at the moment
  • publications/index.md has been added but is still unpopulated

The current branch can be reviewed at https://ngff.readthedocs.io/en/rtd/about/index.html . Once this PR is merged, https://ngff.readthedocs.io/en/latest/about/index.html would become a new default landing location without further configuration and the URLs needed can redirect to, e.g., https://ngff.readthedocs.io/en/latest/tools/

We should likely consider renaming the sphinx-specific latest to not conflict with the spec-specific latest, otherwise we get a default URL of https://ngff.readthedocs.io/en/latest/latest/index.html . If there's a general consensus, we could also redirect https://ngff.openmicroscopy.org away from GitHub pages and to https://ngff.readthedocs.io. Additionally, we can drop the redirect to latest/index.html in favor of a top-level landing page like about/index.md.

TODOS:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

Automated Review URLs

@will-moore
Copy link
Member

Looks nice! 👍

@bogovicj
Copy link
Contributor

Is it right that this could help divide "strictly spec" from "spec-adjacent" (e.g. examples) to different pages? Hopefully resulting in a less cluttered spec?

@joshmoore
Copy link
Member Author

From my POV, that's certainly an option, sure. An additional next step that could go in the description of this PR but I didn't really want to get in is that we could drop bikeshed in favor of some flavor of plain markdown. That might make it easier to refactor more readily in this repo.

@joshmoore
Copy link
Member Author

Ok, I think that includes all the "must-fix" items. Biggest question remaining in my mind is whether or not to set the Single version flag:

A single version site has no translations and only your "latest" version, served at the root of the domain. Use this with caution, only turn it on if you will never have multiple versions of your docs.

If we do that, then once DNS is re-directed, all previous URLs should continue working.

@joshmoore
Copy link
Member Author

Discussing during the "Zarr Resources" call with @will-moore and @pwalczysko, we're going to merge this and drop the en/latest from the URL in order to prepare for DNS migration.

@joshmoore joshmoore merged commit 82152e3 into main Apr 21, 2023
@joshmoore joshmoore deleted the rtd branch April 21, 2023 12:51
github-actions bot added a commit that referenced this pull request Apr 21, 2023
Proposal: move to RTD

SHA: 82152e3
Reason: push, by @joshmoore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@joshmoore
Copy link
Member Author

@ome/ngff: https://ngff.openmicroscopy.org/data/ is now live with a DNS entry to readthedocs.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants