-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust README #72
Adjust README #72
Conversation
README.md
Outdated
|
||
If a dialog in napari pops up, encouraging you to choose a reader, choose ``napari-ome-zarr`` and click OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could mention that you can specify the plugin on cli with napari --plugin napari-ome-zarr "https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.3/9836842.zarr/"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 509461c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why the difference when the file is local. But you say "If a dialog in napari pops up, encouraging you to choose a reader, choose napari-ome-zarr
and click OK."
If that happens, you can stop it happening with --plugin napari-ome-zarr
, regardless of whether the file is local or not. So I would mention --plugin napari-ome-zarr
option before mentioning local usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 2680af2
|
||
napari.run() | ||
|
||
If single zarray is passed to the plugin, it will be opened without the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried this, I didn't need the napari.run()
at least in a python terminal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, can confirm this in python terminal. But if you leave it out in the script, then napari opens and immediately closes. With the napari.run()
in the script, napari persists and is usable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah 👍
Codecov ReportBase: 92.43% // Head: 88.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 92.43% 88.33% -4.10%
==========================================
Files 3 2 -1
Lines 185 180 -5
==========================================
- Hits 171 159 -12
- Misses 14 21 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Tested the README workflow
Adjusted:
0
subfolder opening routine, as it crashes atmcc @jburel @will-moore