Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md for docker compose v2 #14

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Update README.md for docker compose v2 #14

merged 3 commits into from
Jul 28, 2023

Conversation

jackyko1991
Copy link
Contributor

@pwalczysko
Copy link
Member

pwalczysko commented Jul 27, 2023 •
edited
Loading

@jackyko1991
Do you want to update the tests as well please ? https://github.com/ome/docker-example-omero/blob/master/test.sh

@jackyko1991
Update test.sh
76a3c85 
docker compose v2
@jackyko1991
Update wait_for_login.sh
e7f0819 
docker compose v2
@jackyko1991
Copy link
Contributor Author

@pwalczysko files updated accordingly

@pwalczysko
Copy link
Member

Do you want to approve the GA workflow please @jburel @joshmoore or @sbesson ?

@joshmoore
Copy link
Member

If the tests are passing, this makes sense to me. I've not updated the habit myself, but maybe this will help. Thanks, @jackyko1991!

@joshmoore joshmoore merged commit a4a3ef9 into ome:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackyko1991 @pwalczysko @joshmoore